Skip to content

Jackie - Ampers - Api muncher#23

Open
Jackiesan wants to merge 21 commits intoAda-C9:masterfrom
Jackiesan:master
Open

Jackie - Ampers - Api muncher#23
Jackiesan wants to merge 21 commits intoAda-C9:masterfrom
Jackiesan:master

Conversation

@Jackiesan
Copy link

@Jackiesan Jackiesan commented May 7, 2018

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I used postman to understand the responses. I also tested different syntax options in the api documentation to compare the responses.
Describe your API Wrapper. How did you decide on the methods you created? I created 2 methods in the api wrapper. The first method is responsible for returning an array of hits (recipes). The second is responsible for returning one specific recipe which is used in the show method of the controller.
Describe an edge case or failure case test you wrote for your API Wrapper. I wrote a controller test that asserts that there is a redirection to root path if the recipe uri does not exist for the show method.
Explain how VCR aids in testing an API. VCR records the response of an api call the first time that the test is run. That information is stored in a cassette which can then be used to replay for future testing of that response. This is helpful because it means that the tests will not make new calls when they are run.
What is the Heroku URL of your deployed application? https://seattle-muncher.herokuapp.com/
Provide a link to the Trello board you used https://trello.com/b/VUu9CwwQ/recipe

Jackiesan added 21 commits May 1, 2018 20:32
@Jackiesan
Added rails and updated gem files
17cfee1
@Jackiesan
Added files to git ignore file
1fb6a35
@Jackiesan
Created form for search, updated recipes controller, updated index an…
f65be01 
…d show
@Jackiesan
Updated show controller
08e995b
@Jackiesan
Added VCR to gemfile and test helper, added lib test recipe.rb
9f84a0c
@Jackiesan
Added tests
295743d
@Jackiesan
Added VCR and created first test for EdamamApiWrapper
fd3788c
@Jackiesan
Completed controller tests and 2 assertions for api wrapper
0529cd9
@Jackiesan
Added assertions for api wrapper show method
f6ff67d
@Jackiesan
Added navigation bar to certain pages
e24a657
@Jackiesan
Changed config.autoload_paths to config.eager_load_paths
2c65c02
@Jackiesan
Added styling to home page to be responsive
0702a56
@Jackiesan
Added styling to index recipe page
caaef50
@Jackiesan
Added search bar to index and show pages
3bd4cc1
@Jackiesan
Added pagination and updated styling for pagination bar
519e22e
@Jackiesan
Added styles to show page and added url link to recipe initialization
88d2696
@Jackiesan
changed button to see recipe link
6be193c
@Jackiesan
Updated test for recipe initialization responding to url
e07cebe
@Jackiesan
Revised method find recipe
86b215b
@Jackiesan
Updated code in find recipe to pass controller tests and consider inv…
7655a02 
…alid ids
@Jackiesan
Added targets to link to open new tab
542e994
@CheezItMan
Copy link

CheezItMan commented May 14, 2018

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits, good commit messages
Comprehension questions Check
General
Rails fundamentals (RESTful routing, use of named paths) Check,
Semantic HTML See my notes, avoid using div elements so much
Errors are reported to the user No error messages for bad URIs on the show action or empty search results
API Wrapper to handle the API requests Check
Controller testing Check,
Lib testing Check, missing an edge-case on the find-recipe action.
Search Functionality Check
List Functionality Check
Show individual item functionality (link to original recipe opens in new tab) Check
Styling
Responsive layout On the index results yes, on the show page, no.
List View shows 10 items at a time/pagination Check, nice styling there
The app is styled to create an attractive user interface Well done
API Features
The App attributes Edaman Check
The VCR casettes do not contain the API key Check
External Resources
Link to Trello Board Check
Link to deployed app on Heroku Check
Overall Well done, you hit all the learning goal. I did leave some notes in your code on small matters. Let me know if you have any questions.

CheezItMan
CheezItMan reviewed May 14, 2018
View reviewed changes
app/views/layouts/application.html.erb
<h1 class="muncher"><%= link_to "Seattle Muncher", root_path%></h1>

<%= yield %>
<div class="footer">
Copy link

@CheezItMan CheezItMan May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't a footer tag work better?

app/views/recipes/home.html.erb

<div class="container">
<%= form_tag recipes_path, method: :get do %>
<div class="row">
Copy link

@CheezItMan CheezItMan May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toooooo maaaaany div elements

test/controllers/recipes_controller_test.rb
must_respond_with :success
end

it "can get recipes index" do
Copy link

@CheezItMan CheezItMan May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test for empty search results?

test/lib/edamam_api_wrapper_test.rb
end
end

it "returns the accurate information of a recipe" do
Copy link

@CheezItMan CheezItMan May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about bad URIs on the find recipe action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jackiesan @CheezItMan